Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Innodb buffer pool mapping #369

Merged
merged 4 commits into from
Mar 11, 2019

Conversation

maeserichar
Copy link
Contributor

@maeserichar maeserichar commented Mar 4, 2019

This is a port of a pull request made in the percona fork of this exporter:

percona#20

Description of the problem in https://jira.percona.com/browse/PMM-1453

As a quick summary, the stats for Innodb_buffer_pool_pages_old and Innodb_buffer_pool_pages_total should be returned as gauges, instead of counters.

@SuperQ

@maeserichar maeserichar force-pushed the innodb_buffer_pool_mapping branch from 3dc8420 to 20d2be6 Compare March 4, 2019 14:30
collector/global_status.go Outdated Show resolved Hide resolved
Ricardo Rodríguez added 3 commits March 7, 2019 09:48
Signed-off-by: Ricardo Rodríguez <rrodriguez@tuenti.com>
Signed-off-by: Ricardo Rodríguez <rrodriguez@tuenti.com>
Signed-off-by: Ricardo Rodríguez <rrodriguez@tuenti.com>
@maeserichar maeserichar force-pushed the innodb_buffer_pool_mapping branch from 087b4ca to 461200c Compare March 7, 2019 08:50
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ
Copy link
Member

SuperQ commented Mar 9, 2019

Oh, would you please update the PR description and add a CHANGELOG entry.

* [CHANGE] Update innodb buffer pool mappings #369 

Signed-off-by: Ricardo Rodríguez <rrodriguez@tuenti.com>
@maeserichar
Copy link
Contributor Author

Changelog updated.

When are you expecting to release a new version?

@SuperQ
Copy link
Member

SuperQ commented Mar 11, 2019

Sadly, this exporter is lower on my priority list, and I've been putting off making a release. I really need to do one soon. 😦

I'm also working a plan to onboard some new maintainers, so features/releases will be more regular.

@SuperQ SuperQ merged commit c947f87 into prometheus:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants