-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for collecting metrics from sys.user_summary #628
Add support for collecting metrics from sys.user_summary #628
Conversation
9eca2e1
to
07440a2
Compare
WOW, I'm just looking for this feature. What do we need to merge such PR? |
28565d6
to
cea00aa
Compare
Please also include the new collector documentation in the top level README.md. |
Done |
* Behavior is controlled by a relevant flag and defaults to False. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
* Remove statement avg latency. * Add _total suffix to counters (removing total_ prefix for some). * Fix some metric types. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
While at it, put heartbeat parameters in alphabetical order. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
Co-authored-by: Ben Kochie <superq@gmail.com> Signed-off-by: Eduardo J. Ortega U. <5791035+ejortegau@users.noreply.github.com> Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
a4e4331
to
97bf94e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more metric unit issue, otherwise LGTM.
Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for all the review changes.
I think I accidentally clicked on |
BREAKING CHANGES: The exporter no longer supports the monolithic `DATA_SOURCE_NAME` environment variable. To configure connections to MySQL you can either use a `my.cnf` style config file or command line arguments. For example: export MYSQLD_EXPORTER_PASSWORD=secret mysqld_exporter --mysqld.address=localhost:3306 --mysqld.username=exporter We have also dropped some internal scrape metrics: * `mysql_exporter_scrapes_total` * `mysql_exporter_scrape_errors_total` * `mysql_last_scrape_failed` Changes: * [CHANGE] Allow tlsCfg.InsecureSkipVerify outside of mTLS #631 * [CHANGE] Update to exporter-toolkit v0.8.1 #677 * [CHANGE] Fix shared metrics between requests #722 * [FEATURE] Add support for collecting metrics from sys.user_summary #628 * [FEATURE] Support for multi-target mysqld probes #651 * [FEATURE] Add MySQL TLS configurations #718 * [BUGFIX] Fix infoSchemaInnodbMetricsEnabledColumnQuery #687 Signed-off-by: SuperQ <superq@gmail.com>
BREAKING CHANGES: The exporter no longer supports the monolithic `DATA_SOURCE_NAME` environment variable. To configure connections to MySQL you can either use a `my.cnf` style config file or command line arguments. For example: export MYSQLD_EXPORTER_PASSWORD=secret mysqld_exporter --mysqld.address=localhost:3306 --mysqld.username=exporter We have also dropped some internal scrape metrics: * `mysql_exporter_scrapes_total` * `mysql_exporter_scrape_errors_total` * `mysql_last_scrape_failed` Changes: * [CHANGE] Allow tlsCfg.InsecureSkipVerify outside of mTLS #631 * [CHANGE] Update to exporter-toolkit v0.8.1 #677 * [CHANGE] Fix shared metrics between requests #722 * [FEATURE] Add support for collecting metrics from sys.user_summary #628 * [FEATURE] Support for multi-target mysqld probes #651 * [FEATURE] Add MySQL TLS configurations #718 * [BUGFIX] Fix infoSchemaInnodbMetricsEnabledColumnQuery #687 Signed-off-by: SuperQ <superq@gmail.com>
* [CHANGE] Allow `tlsCfg.InsecureSkipVerify` outside of mTLS #631 * [CHANGE] Update to exporter-toolkit v0.8.1 #677 * [CHANGE] Fix shared metrics between requests #722 * [FEATURE] Add support for collecting metrics from `sys.user_summary` #628 * [FEATURE] Support for multi-target mysqld probes #651 * [FEATURE] Add MySQL TLS configurations #718 * [ENHANCEMENT] Add UNIX domain socket support for multi-target scraping #707 * [BUGFIX] Fix `infoSchemaInnodbMetricsEnabledColumnQuery` #687 * [BUGFIX] Allow empty passwords #742 Signed-off-by: SuperQ <superq@gmail.com>
* [CHANGE] Allow `tlsCfg.InsecureSkipVerify` outside of mTLS #631 * [CHANGE] Update to exporter-toolkit v0.8.1 #677 * [CHANGE] Fix shared metrics between requests #722 * [FEATURE] Add support for collecting metrics from `sys.user_summary` #628 * [FEATURE] Support for multi-target mysqld probes #651 * [FEATURE] Add MySQL TLS configurations #718 * [ENHANCEMENT] Add UNIX domain socket support for multi-target scraping #707 * [BUGFIX] Fix `infoSchemaInnodbMetricsEnabledColumnQuery` #687 * [BUGFIX] Allow empty passwords #742 Signed-off-by: SuperQ <superq@gmail.com>
BREAKING CHANGES: The exporter no longer supports the monolithic `DATA_SOURCE_NAME` environment variable. To configure connections to MySQL you can either use a `my.cnf` style config file or command line arguments. For example: export MYSQLD_EXPORTER_PASSWORD=secret mysqld_exporter --mysqld.address=localhost:3306 --mysqld.username=exporter We have also dropped some internal scrape metrics: - `mysql_exporter_scrapes_total` - `mysql_exporter_scrape_errors_total` - `mysql_last_scrape_failed` The default client configuration file is now `.my.cnf` in the process working directory. Use `--config.my-cnf="$HOME/.my.cnf"` to retain the previous default. Changes: * [CHANGE] Allow `tlsCfg.InsecureSkipVerify` outside of mTLS #631 * [CHANGE] Update to exporter-toolkit v0.8.1 #677 * [CHANGE] Fix shared metrics between requests #722 * [CHANGE] Allow empty passwords #742 * [CHANGE] Don't use HOME env in the my-cnf config path. #745 * [FEATURE] Add support for collecting metrics from `sys.user_summary` #628 * [FEATURE] Support for multi-target mysqld probes #651 * [FEATURE] Add MySQL TLS configurations #718 * [FEATURE] Add config reload via /-/reload #734 * [ENHANCEMENT] Add UNIX domain socket support for multi-target scraping #707 * [ENHANCEMENT] Use `STRAIGHT_JOIN` in infoSchemaAutoIncrementQuery #726 * [BUGFIX] Fix `infoSchemaInnodbMetricsEnabledColumnQuery` #687 * [BUGFIX] Allow empty passwords #742 Signed-off-by: SuperQ <superq@gmail.com>
BREAKING CHANGES: The exporter no longer supports the monolithic `DATA_SOURCE_NAME` environment variable. To configure connections to MySQL you can either use a `my.cnf` style config file or command line arguments. For example: export MYSQLD_EXPORTER_PASSWORD=secret mysqld_exporter --mysqld.address=localhost:3306 --mysqld.username=exporter We have also dropped some internal scrape metrics: - `mysql_exporter_scrapes_total` - `mysql_exporter_scrape_errors_total` - `mysql_last_scrape_failed` The default client configuration file is now `.my.cnf` in the process working directory. Use `--config.my-cnf="$HOME/.my.cnf"` to retain the previous default. Changes: * [CHANGE] Allow `tlsCfg.InsecureSkipVerify` outside of mTLS #631 * [CHANGE] Update to exporter-toolkit v0.8.1 #677 * [CHANGE] Fix shared metrics between requests #722 * [CHANGE] Allow empty passwords #742 * [CHANGE] Don't use HOME env in the my-cnf config path. #745 * [FEATURE] Add support for collecting metrics from `sys.user_summary` #628 * [FEATURE] Support for multi-target mysqld probes #651 * [FEATURE] Add MySQL TLS configurations #718 * [FEATURE] Add config reload via /-/reload #734 * [ENHANCEMENT] Add UNIX domain socket support for multi-target scraping #707 * [ENHANCEMENT] Use `STRAIGHT_JOIN` in infoSchemaAutoIncrementQuery #726 * [BUGFIX] Fix `infoSchemaInnodbMetricsEnabledColumnQuery` #687 * [BUGFIX] Allow empty passwords #742 Signed-off-by: SuperQ <superq@gmail.com>
Behavior is controlled by a relevant flag and defaults to False.
This addresses feature request #627