Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd: Clarify private flag description #1587

Merged
merged 1 commit into from
Feb 15, 2020
Merged

Conversation

discordianfish
Copy link
Member

This requires root, so it shouldn't be used.

This closes #1246

collector/systemd_linux.go Outdated Show resolved Hide resolved
@SuperQ
Copy link
Member

SuperQ commented Jan 18, 2020

Just need to fix the DCO. 😹

@SuperQ
Copy link
Member

SuperQ commented Jan 25, 2020

Ping, can you fix the DCO signing?

@discordianfish discordianfish force-pushed the discordianfish-patch-1 branch 2 times, most recently from 99d9053 to 532d0b0 Compare February 10, 2020 16:17
This requires root, so it shouldn't be used.

This closes #1246

Signed-off-by: Johannes 'fish' Ziemke <github@freigeist.org>
@discordianfish
Copy link
Member Author

ugh why can't github provide that on the web UI...
@SuperQ done

@grobie grobie merged commit dcfd610 into master Feb 15, 2020
@grobie grobie deleted the discordianfish-patch-1 branch February 15, 2020 10:39
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
This requires root, so it shouldn't be used.

This closes prometheus#1246

Signed-off-by: Johannes 'fish' Ziemke <github@freigeist.org>
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
This requires root, so it shouldn't be used.

This closes prometheus#1246

Signed-off-by: Johannes 'fish' Ziemke <github@freigeist.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--collector.systemd.private requires root
3 participants