Add flag to ignore certain filesystem types #217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,6 +26,7 @@ import ( | |||
|
|
|||
| const ( | |||
| defIgnoredMountPoints = "^/(sys|proc|dev)($|/)" | |||
| defIgnoredFsTypes = "^(sys|proc)fs$" | |||
There was a problem hiding this comment.
On my machine there's also at least devpts, pstore, binfmt_misc and cgroup
|
@dominikschulz ping. Would love to integrate this. Do you have time to address the comments? |
|
This would be really helpful. I am using an exclusion of the following meaningless FS types when graphing disk space |
|
It's not safe to ignore |
mrwacky42
pushed a commit
to mrwacky42/node_exporter
that referenced
this pull request
May 13, 2016
juliusv
added a commit
that referenced
this pull request
Jun 6, 2016
Add flag to ignore certain filesystem types (Copy of #217)
|
Now that #241 is merged, this can be closed, no ? |
|
Seems like it to me, @juliusv? |
|
Seems like it, yeah. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a flag to ignore certain filesystem types. In our setup there are a lot of useless timeseries exported which all share a few filesystem types. This would add a way to ignore all those and save some precious space.
Please let me know if you have any objections in general against this kind of feature.