Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize UTF-8 in dmi collector #2229

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Sanitize UTF-8 in dmi collector #2229

merged 1 commit into from
Dec 1, 2021

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented Nov 29, 2021

Replace invalid UTF-8 chars with "�" string.

Fixes: #2228

Signed-off-by: Ben Kochie superq@gmail.com

@SuperQ
Copy link
Member Author

SuperQ commented Nov 29, 2021

CC @bdrung

Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test would be nice but LGTM either way

@SuperQ SuperQ force-pushed the superq/dmi_utf8 branch 2 times, most recently from 0f0ec17 to b2a8995 Compare December 1, 2021 09:09
Replace invalid UTF-8 chars with "�" string.

Fixes: #2228

Signed-off-by: Ben Kochie <superq@gmail.com>
@SuperQ SuperQ merged commit 1d5afd0 into master Dec 1, 2021
@SuperQ SuperQ deleted the superq/dmi_utf8 branch December 1, 2021 10:13
SuperQ added a commit that referenced this pull request Dec 1, 2021
* [BUGFIX] Handle nil CPU thermal power status on M1 #2218
* [BUGFIX] bsd: Ignore filesystems flagged as MNT_IGNORE. #2227
* [BUGFIX] Sanitize UTF-8 in dmi collector #2229

Signed-off-by: Ben Kochie <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request Dec 1, 2021
SuperQ added a commit that referenced this pull request Dec 4, 2021
* [BUGFIX] Handle nil CPU thermal power status on M1 #2218
* [BUGFIX] bsd: Ignore filesystems flagged as MNT_IGNORE. #2227
* [BUGFIX] Sanitize UTF-8 in dmi collector #2229

Signed-off-by: Ben Kochie <superq@gmail.com>
SuperQ added a commit that referenced this pull request Dec 4, 2021
Replace invalid UTF-8 chars with "�" string.

Fixes: #2228

Signed-off-by: Ben Kochie <superq@gmail.com>
SuperQ added a commit that referenced this pull request Dec 4, 2021
* [BUGFIX] Handle nil CPU thermal power status on M1 #2218
* [BUGFIX] bsd: Ignore filesystems flagged as MNT_IGNORE. #2227
* [BUGFIX] Sanitize UTF-8 in dmi collector #2229

Signed-off-by: Ben Kochie <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request Dec 4, 2021
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
Replace invalid UTF-8 chars with "�" string.

Fixes: prometheus#2228

Signed-off-by: Ben Kochie <superq@gmail.com>
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
* [BUGFIX] Handle nil CPU thermal power status on M1 prometheus#2218
* [BUGFIX] bsd: Ignore filesystems flagged as MNT_IGNORE. prometheus#2227
* [BUGFIX] Sanitize UTF-8 in dmi collector prometheus#2229

Signed-off-by: Ben Kochie <superq@gmail.com>
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
Replace invalid UTF-8 chars with "�" string.

Fixes: prometheus#2228

Signed-off-by: Ben Kochie <superq@gmail.com>
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
* [BUGFIX] Handle nil CPU thermal power status on M1 prometheus#2218
* [BUGFIX] bsd: Ignore filesystems flagged as MNT_IGNORE. prometheus#2227
* [BUGFIX] Sanitize UTF-8 in dmi collector prometheus#2229

Signed-off-by: Ben Kochie <superq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: label value "\xc0\x1c[\x87" is not valid UTF-8
3 participants