-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanitize UTF-8 in dmi collector #2229
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
force-pushed
the
superq/dmi_utf8
branch
from
November 29, 2021 09:52
fa7a466
to
f49203b
Compare
CC @bdrung |
bdrung
reviewed
Nov 29, 2021
discordianfish
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test would be nice but LGTM either way
SuperQ
force-pushed
the
superq/dmi_utf8
branch
2 times, most recently
from
December 1, 2021 09:09
0f0ec17
to
b2a8995
Compare
Replace invalid UTF-8 chars with "�" string. Fixes: #2228 Signed-off-by: Ben Kochie <superq@gmail.com>
SuperQ
force-pushed
the
superq/dmi_utf8
branch
from
December 1, 2021 09:25
b2a8995
to
b12daff
Compare
Merged
SuperQ
added a commit
that referenced
this pull request
Dec 4, 2021
SuperQ
added a commit
that referenced
this pull request
Dec 4, 2021
Replace invalid UTF-8 chars with "�" string. Fixes: #2228 Signed-off-by: Ben Kochie <superq@gmail.com>
SuperQ
added a commit
that referenced
this pull request
Dec 4, 2021
Merged
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
Replace invalid UTF-8 chars with "�" string. Fixes: prometheus#2228 Signed-off-by: Ben Kochie <superq@gmail.com>
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
* [BUGFIX] Handle nil CPU thermal power status on M1 prometheus#2218 * [BUGFIX] bsd: Ignore filesystems flagged as MNT_IGNORE. prometheus#2227 * [BUGFIX] Sanitize UTF-8 in dmi collector prometheus#2229 Signed-off-by: Ben Kochie <superq@gmail.com>
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
Replace invalid UTF-8 chars with "�" string. Fixes: prometheus#2228 Signed-off-by: Ben Kochie <superq@gmail.com>
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
* [BUGFIX] Handle nil CPU thermal power status on M1 prometheus#2218 * [BUGFIX] bsd: Ignore filesystems flagged as MNT_IGNORE. prometheus#2227 * [BUGFIX] Sanitize UTF-8 in dmi collector prometheus#2229 Signed-off-by: Ben Kochie <superq@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace invalid UTF-8 chars with "�" string.
Fixes: #2228
Signed-off-by: Ben Kochie superq@gmail.com