sanitize rapl zone name

[sourikghosh]

hotfix for rapl collector crash sanitizing the rapl zone name for invalid metrics name.
closes #2299

[baryluk]

Test?

[sourikghosh]

yeah ok adding

[SuperQ]

Hmm, maybe this is one of those that we should make a label instead of mashing the metric name.

[sourikghosh]

@SuperQ any update on this ?? Do we need to fix this ??

[SuperQ]

@discordianfish What do you think? Should we move the rapl zone into a rapl_zone label?

[baryluk]

Here is the content of the relevant sysfs files from the machine that was a reason to fill the bug:

# for f in `find /sys/ | grep rapl | grep -E 'uj|name'`; do grep -H . $f; done
/sys/devices/virtual/powercap/intel-rapl/intel-rapl:0/energy_uj:9169789504
/sys/devices/virtual/powercap/intel-rapl/intel-rapl:0/intel-rapl:0:0/energy_uj:36263586493
/sys/devices/virtual/powercap/intel-rapl/intel-rapl:0/intel-rapl:0:0/name:core
/sys/devices/virtual/powercap/intel-rapl/intel-rapl:0/intel-rapl:0:0/max_energy_range_uj:65532610987
/sys/devices/virtual/powercap/intel-rapl/intel-rapl:0/name:package-0-die-0
/sys/devices/virtual/powercap/intel-rapl/intel-rapl:0/max_energy_range_uj:65532610987

CPU: Model name: AMD EPYC 7401P 24-Core Processor

Maybe it will help.

[sourikghosh]

@discordianfish Will you share your kind opinion on this?

@discordianfish What do you think? Should we move the rapl zone into a rapl_zone label?

[discordianfish]

@SuperQ Yes, that would be cleaner. It's a breaking change though so I'm fine either way.

[sourikghosh]

@SuperQ @discordianfish Should I close this PR or we can go ahead with this?

[discordianfish]

@sourikghosh Yes, let's use a label for this.