Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow graceful failure in hwmon collector #427

Merged
merged 1 commit into from
Jan 17, 2017
Merged

Allow graceful failure in hwmon collector #427

merged 1 commit into from
Jan 17, 2017

Conversation

mdlayher
Copy link
Contributor 

$ ./node_exporter -web.listen-address 192.168.1.1:9100 -collectors.enabled hwmon -log.level debug
INFO[0000] Starting node_exporter (version=, branch=, revision=)  source="node_exporter.go:136"
INFO[0000] Build context (go=go1.7.4, user=, date=)      source="node_exporter.go:137"
INFO[0000] Enabled collectors:                           source="node_exporter.go:156"
INFO[0000]  - hwmon                                      source="node_exporter.go:158"
INFO[0000] Listening on 192.168.1.1:9100                 source="node_exporter.go:176"
DEBU[0001] hwmon collector metrics are not available for this system  source="hwmon_linux.go:404"
DEBU[0001] OK: hwmon collector succeeded after 0.002255s.  source="node_exporter.go:95"

Fixes #426

grobie
grobie approved these changes Jan 17, 2017
View reviewed changes
Copy link
Member

@grobie grobie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@grobie grobie merged commit 0429a4f into prometheus:master Jan 17, 2017
@mdlayher mdlayher deleted the hwmon-silent-fail branch January 17, 2017 16:50
@SuperQ SuperQ mentioned this pull request Jan 19, 2017
Closed
tamcore pushed a commit to gitgrave/node_exporter that referenced this pull request Oct 22, 2024
@DavidVentura
Add isolated cpu parsing (prometheus#427)
c6f5590 
* Add isolated cpu parsing

Signed-off-by: david <davidventura27@gmail.com>

* Address PR comments

Signed-off-by: david <davidventura27@gmail.com>

* Fix start/end range message

Signed-off-by: david <davidventura27@gmail.com>

* rename to parseIsolatedCPUs

Signed-off-by: david <davidventura27@gmail.com>

* Do not wrap error

Signed-off-by: david <davidventura27@gmail.com>

* also check error is nil

Signed-off-by: david <davidventura27@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grobie grobie grobie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdlayher @grobie