Remove obsolete megacli collector. #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| @@ -80,7 +80,14 @@ tcpstat | Exposes TCP connection status information from `/proc/net/tcp` and `/p | |||
| Name | Description | OS | |||
| ---------|-------------|---- | |||
| gmond | Exposes statistics from Ganglia. | _any_ | |||
| megacli | Exposes RAID statistics from MegaCLI. | Linux | |||
|
|
|||
| ### Removed | |||
There was a problem hiding this comment.
Do you really need to mention these still?
There was a problem hiding this comment.
+1 for omitting this entirely.
There was a problem hiding this comment.
We never updated the README with a mention of the new textfile collector. I wanted there be some way of knowing where to find it.
This collector has been replaced by the textfile collector tool `storcli.py`.
SuperQ
force-pushed
the
superq/remove_megacli_collector
branch
from
e58e91c to
c411f33
Compare
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
This collector has been replaced by the textfile collector tool `storcli.py`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This collector has been replaced by the textfile collector tool
storcli.py.