Correct the ClocksPerSec scaling factor on Darwin #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the definition of ClocksPerSec to read from limits.h
SuperQ
reviewed
Mar 7, 2018
collector/cpu_darwin.go
Outdated
| @@ -45,7 +46,7 @@ import ( | |||
| import "C" | |||
|
|
|||
| // ClocksPerSec default value. from time.h | |||
| const ClocksPerSec = float64(128) | |||
| const ClocksPerSec = C.CLK_TCK | |||
There was a problem hiding this comment.
We want to keep the float64() cast to avoid integer math.
grobie
approved these changes
Mar 7, 2018
|
The circleci build failure is due to Go 1.10 not being in the Circle 1.0 machine. Plus it doesn't test Darwin anyway. I tested this patch locally, looks good. |
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
* Update cpu_darwin.go Change the definition of ClocksPerSec to read from limits.h * Update cpu_darwin.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the definition of ClocksPerSec to read from limits.h
Per #845, CPU counters are scaled by an incorrect factor (128 was assumed, which is the FreeBSD default [?]). Correct value on Darwin is given by the C macro CLK_TCK in limits.h