Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a iscsi stats collector #961

Closed

Conversation

hassanshabbirahmed
Copy link

Adding a very simple iscsistats collector to collect stats around iscsi sessions if there are any.

@SuperQ
Copy link
Member

SuperQ commented May 31, 2018

Thanks, good idea. We prefer to add new collectors like this by using our procfs library to implement the reading of files from /sys. This helps us generate unit tests and deal with things like running inside Docker where /sys may be in a different location.

Take a look at the recent /sys/class/net PRs:

@SuperQ
Copy link
Member

SuperQ commented May 31, 2018

Also, you may want to consider using branch-based fork workflow for your development. This will make it easier to keep your fork's master branch in sync with the upstream.

@hassanshabbirahmed
Copy link
Author

thanks for the feedback @SuperQ , i'll close this one and do as suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants