Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NRestarts counter introduced in systemd 235 #992

Merged
merged 3 commits into from
Jul 5, 2018
Merged

Add support for NRestarts counter introduced in systemd 235 #992

merged 3 commits into from
Jul 5, 2018

Conversation

xginn8
Copy link
Contributor

@xginn8 xginn8 commented Jul 3, 2018

.service units increment this counter any time the Restart= condition is
triggered.

`.service` units increment this counter any time the Restart= condition is
triggered.

Signed-off-by: Matthew McGinn <mamcgi@gmail.com>
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM.

Signed-off-by: Matthew McGinn <mamcgi@gmail.com>
CHANGELOG.md Outdated
@@ -2,7 +2,7 @@

**Breaking changes**

* [CHANGE]
* [CHANGE] Collect NRestarts property for systemd service units
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go under feature.

Signed-off-by: Matthew McGinn <mamcgi@gmail.com>
Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM beside SuperQ's comment

@SuperQ SuperQ merged commit 8af84a2 into prometheus:master Jul 5, 2018
@pgier pgier mentioned this pull request Feb 6, 2019
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
…us#992)

* Add support for NRestarts counter introduced in systemd 235

`.service` units increment this counter any time the Restart= condition is
triggered.

Signed-off-by: Matthew McGinn <mamcgi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants