Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error parsing /sys/class/power_supply #205

Closed
shaardie opened this issue Sep 2, 2019 · 1 comment
Closed

Error parsing /sys/class/power_supply #205

shaardie opened this issue Sep 2, 2019 · 1 comment
Labels
bug

Comments

@shaardie
Copy link
Contributor

shaardie commented Sep 2, 2019

There is a problem while parsing the /sys/class/power_supply/<power_supply>/device, since this is a symlink to a directory, but sysfs/class_power_supply.go tries to read it like a regular file.
shaardie added a commit to shaardie/procfs that referenced this issue Sep 2, 2019
@shaardie
Fix parsing of /sys/class/power_supply
a67fc63 
The file `/sys/class/power_supply/<power_supply>/device` is a symlink to a
directory, but it is read as a regular file. This commit fixes this problem and
tries to solve prometheus#205.

Also it updates the fixtures.ttar file and add the symlink in it to better
represent the situation on the pc.

Signed-off-by: Sven Haardiek <sven@haardiek.de>
@shaardie shaardie mentioned this issue Sep 2, 2019
Merged
@pgier pgier added the bug label Sep 4, 2019
pgier pushed a commit that referenced this issue Sep 5, 2019
@shaardie @pgier
Fix parsing of /sys/class/power_supply
7235699 
The file `/sys/class/power_supply/<power_supply>/device` is a symlink to a
directory, but it is read as a regular file. This commit fixes this problem and
tries to solve #205.

Also it updates the fixtures.ttar file and add the symlink in it to better
represent the situation on the pc.

Signed-off-by: Sven Haardiek <sven@haardiek.de>
@pgier
Copy link
Collaborator

pgier commented Sep 5, 2019

Fixed by #206

@pgier pgier closed this as completed Sep 5, 2019
remijouannet pushed a commit to remijouannet/procfs that referenced this issue Oct 20, 2022
@shaardie @pgier
Fix parsing of /sys/class/power_supply
12b71bc 
The file `/sys/class/power_supply/<power_supply>/device` is a symlink to a
directory, but it is read as a regular file. This commit fixes this problem and
tries to solve prometheus#205.

Also it updates the fixtures.ttar file and add the symlink in it to better
represent the situation on the pc.

Signed-off-by: Sven Haardiek <sven@haardiek.de>
bobrik pushed a commit to bobrik/procfs that referenced this issue Jan 14, 2023
@eminence
Merge pull request prometheus#205 from tatref/fix-ci
6b3aff0 
fix CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pgier @shaardie