Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase Initial support for parsing /proc/net/arp #105 from @skottler #199

Merged
merged 2 commits into from
Aug 15, 2019

Conversation

TheMeier
Copy link
Contributor

@TheMeier TheMeier commented Aug 3, 2019

Rebase and slightly refactor abandoned PR #105

Signed-off-by: Christoph Maser christoph.maser+github@gmail.com

/cc prometheus/node_exporter#540 where this was originally discussed
/cc prometheus/node_exporter#535

…skottler

Signed-off-by: Christoph Maser <christoph.maser+github@gmail.com>
Copy link
Collaborator

@pgier pgier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor comment.

arp.go Show resolved Hide resolved
Signed-off-by: Christoph Maser <christoph.maser+github@gmail.com>
Copy link
Collaborator

@pgier pgier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgier pgier merged commit 6df1103 into prometheus:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants