additional error handling when reading files in /sys/class #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some regular files in /sys/class are not readable on certain systems, so just ignore them. Signed-off-by: Paul Gier <pgier@redhat.com>
|
See also prometheus/node_exporter#1465 |
bobrik
pushed a commit
to bobrik/procfs
that referenced
this pull request
Jan 14, 2023
Update to rustix 0.36.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some regular files in /sys/class are not readable on certain
systems, so just ignore them.
Related to #213 which checks that directory entries are regular files and not symlinks. However, there is the additional problem that some files in /sys/class/ (e.g.
/sys/class/net/enp0s31f6/phys_port_id) are not readable even though they are regular files. Before the recent refactoring, these read errors were ignored. This change makes these errors ignored again.