Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slabinfo support #328

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Conversation

hodgesds
Copy link
Contributor

@hodgesds hodgesds commented Sep 16, 2020

This patch adds support for reading slab info from /proc/slabinfo. This is to potentially add support in node_exporter (see #1799). One thing to note is that reading from /proc/slabinfo requires root/CAP_SYS_ADMIN to read, see the slabinfo man page and kernel slub documentation.

@hodgesds hodgesds force-pushed the slabinfo branch 3 times, most recently from e5d7cc2 to c38dfea Compare September 16, 2020 01:08
This patch adds support for reading slab info from /proc/slabinfo.
For more info see man 5 slabinfo.

Signed-off-by: Daniel Hodges <hodges.daniel.scott@gmail.com>
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not likely to include CAP_SYS_ADMIN in the node_exporter, but this is fine for this library use.

@hodgesds
Copy link
Contributor Author

hodgesds commented Feb 5, 2021

Sounds reasonable

Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@discordianfish discordianfish merged commit 8cf1637 into prometheus:master Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants