Mark sysfs as Linux-only #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Fratto <robertfratto@gmail.com>
|
Maybe we should mark everything under |
Signed-off-by: Robert Fratto <robertfratto@gmail.com>
Yep, agreed. Changed the PR to do this. Thanks! |
|
Do we need a second pair of eyes to get this merged? |
|
Sorry, fell out of my TODO list. |
3 tasks
remijouannet
pushed a commit
to remijouannet/procfs
that referenced
this pull request
Oct 20, 2022
…freebsd Mark sysfs as Linux-only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sysfs package is imported by node_exporter.
class_thermalusesENODATA, which doesn't exist on FreeBSD, so the build fails.Since sysfs is a Linux concept, this PR marks most of the functions within the package as Linux-only. Closes #359.