Merge pull request #65 from prometheus/beorn7/histogram

Properly set the sum in a histogram
prometheus · Jul 23, 2019 · b7b4ff1 · b7b4ff1
2 parents 9ab3b30 + 36c1adb
commit b7b4ff1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/prom2json.go b/prom2json.go
@@ -85,7 +85,7 @@ func NewFamily(dtoMF *dto.MetricFamily) *Family {
 				TimestampMs: makeTimestamp(m),
 				Buckets:     makeBuckets(m),
 				Count:       fmt.Sprint(m.GetHistogram().GetSampleCount()),
-				Sum:         fmt.Sprint(m.GetSummary().GetSampleSum()),
+				Sum:         fmt.Sprint(m.GetHistogram().GetSampleSum()),
 			}
 		} else {
 			mf.Metrics[i] = Metric{

diff --git a/prom2json_test.go b/prom2json_test.go
@@ -207,7 +207,7 @@ var tcs = []testCase{
 						"1e+06":  "5",
 					},
 					Count: "1",
-					Sum:   "0",
+					Sum:   "2",
 				},
 			},
 		},