Close metric family channel in case of errors #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, good point. I'll have a closer look ASAP. (Perhaps there is also a way to solve it more elegantly. But not breaking current users is also a good thing.) |
Thanks for the quick response! 💃 |
beorn7
requested changes
Nov 25, 2019
|
And sorry for the long delay. It was a busy week at KubeCon + CloudNativeCon. |
`FetchMetricFamilies` fails to close the channel if the request fails or can't be constructed correctly (lines 154, 160 and 164). In these cases `ch` is never closed and the caller will probably leak a goroutine when used as a library. This fix doesn't break backwards compatibility. Signed-off-by: Daniel Lohse <daniel.lohse@alfatraining.de>
annismckenzie
force-pushed
the
fix-metric-family-channel-close
branch
from
6e0f2c8
to
5734e44
Compare
No need to apologize, we're good.
That's done. |
beorn7
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FetchMetricFamiliesnever closes the channel if the request fails or can't be constructed correctly (lines 153, 160 and 165). In these caseschis never closed and the caller will probably leak a goroutine when used as a library. This fix doesn't break backwards compatibility.We can't add a
defer close(ch)in line 150 becauseParseResponseitself also closes the channel.