Merge locals() with globals() for context in Python 3.13
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request modifies the context generation in the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
============================== warnings summary ===============================
tests/test_utils.py::test_accumulate
C:\hostedtoolcache\windows\Python\3.13.0\x64\Lib\asyncio\base_events.py:746: RuntimeWarning: coroutine method 'aclose' of 'accumulate_any.<locals>._' was never awaited
self._ready.clear()
Enable tracemalloc to get traceback where the object was allocated.
See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info =========================== |
✅ Deploy Preview for promplate-core ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @CNSeniorious000 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider breaking down the one-liner into multiple lines for improved readability.
- It would be helpful to add a brief comment explaining why the change is necessary for Python 3.13 and above.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -87,7 +88,8 @@ def _on_special_token(self, token, sync: bool): | |||
| @staticmethod | |||
| def _make_context(text: str): | |||
| """generate context parameter if specified otherwise use locals() by default""" | |||
|
|
|||
| if version_info >= (3, 13): | |||
| return f"globals() | locals() | dict({text[text.index(' ') + 1:]})" if " " in text else "globals() | locals()" | |||
| return f"locals() | dict({text[text.index(' ') + 1:]})" if " " in text else "locals()" | |||
There was a problem hiding this comment.
suggestion: Consider refactoring the common condition if " " in text to improve readability.
The condition is repeated in both the new and existing code. Extracting this logic could make the code more maintainable and reduce duplication.
@staticmethod
def _make_context(text: str):
"""generate context parameter if specified otherwise use locals() by default"""
has_extra_context = " " in text
if version_info >= (3, 13):
base_context = "globals() | locals()"
extra = f" | dict({text[text.index(' ') + 1:]})" if has_extra_context else ""
else:
base_context = "locals()"
extra = f" | dict({text[text.index(' ') + 1:]})" if has_extra_context else ""
return f"{base_context}{extra}"
CNSeniorious000
force-pushed
the
fix-3.13-locals
branch
from
a251596
to
1880ad2
Compare
CNSeniorious000
temporarily deployed
to
fix-3.13-locals - promplate python coverage PR #14
Render
Destroyed
CNSeniorious000
changed the title
locals() with globals() for context forwardinglocals() with globals() for context in Python 3.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
locals()forwarding breaks in Python 3.13 #13Summary by Sourcery
Fix context generation by merging
locals()withglobals()for Python 3.13 and above, ensuring correct context forwarding.Bug Fixes:
locals()withglobals()when Python version is 3.13 or higher.