-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: read page as markdown by default #8
Conversation
Deploying reasonify with Cloudflare Pages
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Reviewer's Guide by SourceryThis pull request changes the default behavior of the File-Level Changes
Tips
|
✅ Deploy Preview for reasonify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @CNSeniorious000 - I've reviewed your changes - here's some feedback:
Overall Comments:
- The PR description mentions replacing
html2text
with a fork, but this change is not reflected in the diff. Could you please clarify or update the PR description to accurately reflect the changes made?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Replace
html2text
by a fork, Resolves #7See:
Summary by Sourcery
Set the default parsing format to 'markdown' in the read_page function and update the project version to 0.1.3.
Enhancements:
Chores: