Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: read page as markdown by default #8

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

CNSeniorious000
Copy link
Member

@CNSeniorious000 CNSeniorious000 commented Aug 22, 2024

Replace html2text by a fork, Resolves #7

See:

Summary by Sourcery

Set the default parsing format to 'markdown' in the read_page function and update the project version to 0.1.3.

Enhancements:

  • Change the default parsing format in the read_page function from 'plain' to 'markdown'.

Chores:

  • Update the project version from 0.1.2 to 0.1.3.

@CNSeniorious000 CNSeniorious000 self-assigned this Aug 22, 2024
Copy link

Deploying reasonify with  Cloudflare Pages  Cloudflare Pages

Latest commit: 72b8688
Status: ✅  Deploy successful!
Preview URL: https://22fdffe8.reasonify.pages.dev
Branch Preview URL: https://html2text2.reasonify.pages.dev

View logs

Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reasonify ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 2:55pm

Copy link

sourcery-ai bot commented Aug 22, 2024

Reviewer's Guide by Sourcery

This pull request changes the default behavior of the read_page function to parse web pages as markdown instead of plain text. It also updates the project version from 0.1.2 to 0.1.3.

File-Level Changes

Files Changes
reasonify-headless/reasonify/tools/fetch.py Modified the default value of the parse_as parameter in the read_page function from 'plain' to 'markdown'
reasonify-headless/version.py Incremented the project version from 0.1.2 to 0.1.3

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for reasonify ready!

Name Link
🔨 Latest commit 72b8688
🔍 Latest deploy log https://app.netlify.com/sites/reasonify/deploys/66c7514f308bd900083541c1
😎 Deploy Preview https://deploy-preview-8--reasonify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @CNSeniorious000 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The PR description mentions replacing html2text with a fork, but this change is not reflected in the diff. Could you please clarify or update the PR description to accurately reflect the changes made?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@CNSeniorious000 CNSeniorious000 merged commit c3a8371 into main Aug 22, 2024
21 checks passed
@CNSeniorious000 CNSeniorious000 deleted the html2text2 branch August 22, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

html2text is out of maintenance
1 participant