Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pass usage in Result with passed #49

Open
1 task done
shrink opened this issue Jun 24, 2021 · 0 comments
Open
1 task done

Replace pass usage in Result with passed #49

shrink opened this issue Jun 24, 2021 · 0 comments
Milestone

Comments

@shrink
Copy link
Member

shrink commented Jun 24, 2021

#47 replaced the pass output with passed so from an end-user perspective, the interface makes sense now, however, pass is used internally and externally by Javascript assertions.

I'm not sure how to deal with this mistake in a backwards-compatible way given third-party packages could depend on this interface... however, I don't think anyone is using this Action yet with custom assertions so maybe I can get with fixing it in a backwards-incompatible way.

@shrink shrink added this to the v3 milestone Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant