Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version parameter to npm:// assertions #50

Closed
3 tasks done
shrink opened this issue Jun 24, 2021 · 0 comments · Fixed by #52
Closed
3 tasks done

Add version parameter to npm:// assertions #50

shrink opened this issue Jun 24, 2021 · 0 comments · Fixed by #52
Milestone

Comments

@shrink
Copy link
Member

shrink commented Jun 24, 2021

The live-plugin-manager package accepts a version parameter.

  • Parse version from assertion name using <package>:<version> format
  • Replace all examples with explicit version reference to encourage safe usage
  • Default to v1 not latest for safety and to address Replace pass usage in Result with passed #49?
- name: Test actor is @shrink
  uses: pr-mpt/actions-assert@v2
  with:
    assertion: npm://@assertions/is-equal@v1
    actual: "${{ github.actor }}"
    expected: shrink
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant