Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Poetry v1.2.0 and other related cleanup #20

Merged
merged 9 commits into from
Sep 5, 2022

Conversation

pronovic
Copy link
Owner

@pronovic pronovic commented Sep 5, 2022

Based on the changes between apologies v0.1.36 and v0.1.37 including PR #39, PR #40, and PR #41.

Changes:

  • Upgrade to Poetry v1.2.0
  • Add caching to GitHub Actions workflow
  • Remove the CodeQL workflow, which GitHub keeps disabling anyway
  • Fix matrix build in GitHub Actions to properly execute on multiple platforms
  • Temporarily remove matrix build for the Windows platform

It turns out that I haven't actually been running the GitHub Actions workflow against MacOS and Windows, due to a typo. After fixing that bug, it's apparent that the test suite doesn't actually work in the GitHub Actions environment for Windows, even though everything works fine in my local Windows development environment. So, until I get that figured out, I am temporarily not running the matrix build against Windows. That's not great, but it effectively maintains the status quo.

@pronovic pronovic merged commit e38beca into master Sep 5, 2022
@pronovic pronovic deleted the ken/poetry-1.2.0 branch September 5, 2022 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant