We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It looks like the GitHub reporter (at least) won't report on an issue if we provide the absolute path in the Message object. This is, for instance, what pronto-rubocop does: https://github.com/prontolabs/pronto-rubocop/blob/master/lib/pronto/rubocop/offense_line.rb#L19
Unfortunately, the convenience method to pull this is private: https://github.com/prontolabs/pronto/blob/master/lib/pronto/git/patch.rb#L42
It'd be nice if this were public.
The text was updated successfully, but these errors were encountered:
@apiology I see no problem with this, would you please submit a PR with appropriate test coverage?
Sorry, something went wrong.
Make Pronto::Git::Patch#new_file_path public
6407e25
Fixes prontolabs#366
Make Pronto::Git::Patch#new_file_path public (#369)
bf57503
Fixes #366
Successfully merging a pull request may close this issue.
It looks like the GitHub reporter (at least) won't report on an issue if we provide the absolute path in the Message object. This is, for instance, what pronto-rubocop does: https://github.com/prontolabs/pronto-rubocop/blob/master/lib/pronto/rubocop/offense_line.rb#L19
Unfortunately, the convenience method to pull this is private:
https://github.com/prontolabs/pronto/blob/master/lib/pronto/git/patch.rb#L42
It'd be nice if this were public.
The text was updated successfully, but these errors were encountered: