Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme: PR number can be taken from github context without parsing #389

Merged
merged 1 commit into from
Nov 22, 2020
Merged

Readme: PR number can be taken from github context without parsing #389

merged 1 commit into from
Nov 22, 2020

Conversation

Vasfed
Copy link
Contributor

@Vasfed Vasfed commented Nov 20, 2020

In github actions there's no need to parse the payload file with jq, PR number is already available in github.event.pull_request.number
Also more secure and readable way is to pass env variables via env

@Vasfed Vasfed requested a review from a team as a code owner November 20, 2020 21:39
ashkulz
ashkulz approved these changes Nov 22, 2020
View reviewed changes
Copy link
Member

@ashkulz ashkulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Vasfed!

@ashkulz ashkulz merged commit d834afa into prontolabs:master Nov 22, 2020
@Vasfed Vasfed deleted the doc/fix_github_action_env branch November 22, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashkulz ashkulz ashkulz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vasfed @ashkulz