-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apply snarkjs performance improvement to semaphore package #1787
Conversation
0d5056b
to
e7d6776
Compare
I wonder if this is going to get confusing if the underlying package gets upgraded in the future, and whether we couldn't maintain patches using something like this: https://www.npmjs.com/package/patch-package |
It probably will get confusing, at which point I'd be down to check out |
I really hope that all of this patching is a short-term necessity which will go away via upstreaming a fix to snarkjs. Otherwise yes, I think managing these forks every time a dependency updates is going to be come unmanageable.
|
superceded by #1797, thanks @robknight for the |
No description provided.