-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch circom_runtime to fix semaphore performance in same way that we fixed zk-eddsa-ticket-pcd #1797
Merged
Merged
patch circom_runtime to fix semaphore performance in same way that we fixed zk-eddsa-ticket-pcd #1797
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| diff --git a/node_modules/circom_runtime/build/main.cjs b/node_modules/circom_runtime/build/main.cjs | ||
| index 235f1b6..3098349 100644 | ||
| --- a/node_modules/circom_runtime/build/main.cjs | ||
| +++ b/node_modules/circom_runtime/build/main.cjs | ||
| @@ -77,7 +77,7 @@ async function builder(code, options) { | ||
|
|
||
| options = options || {}; | ||
|
|
||
| - let memorySize = 32767; | ||
| + let memorySize = 0; | ||
| let memory; | ||
| let memoryAllocated = false; | ||
| while (!memoryAllocated){ | ||
| diff --git a/node_modules/circom_runtime/js/witness_calculator.js b/node_modules/circom_runtime/js/witness_calculator.js | ||
| index 7db0bf8..d50bfec 100644 | ||
| --- a/node_modules/circom_runtime/js/witness_calculator.js | ||
| +++ b/node_modules/circom_runtime/js/witness_calculator.js | ||
| @@ -24,7 +24,7 @@ export default async function builder(code, options) { | ||
|
|
||
| options = options || {}; | ||
|
|
||
| - let memorySize = 32767; | ||
| + let memorySize = 0; | ||
| let memory; | ||
| let memoryAllocated = false; | ||
| while (!memoryAllocated){ | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how sure are we that 0 works and it just dynamically allocates correctly + efficiently?
testing seems to work but do you know if the underlying library actually makes the memory grow dynamically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it doesn't work we can always revert. I am planning on doing more research on this in order to be able to confidently submit a PR to the actual repo. IMO based on the testing I've done this is pretty safe.