Update @zk-kit/lean-imt #2184
Merged
Update @zk-kit/lean-imt #2184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/lean-imt-update # Conflicts: # packages/lib/pod/package.json # yarn.lock
|
Oh, I got wrapped up in the process of cleaning up tasks and forgot to actually wait for review on this one. Sorry @rrrliu. I think the risk is minimal so I'll leave it for review-after-merge instead of revering, but let me know if you have concerns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a cleanliness update while I check for changes in our various dependencies. Here's the story behind the updated comment, for posterity:
I originally planned to use 0 as the hash value for PODNull, but decided against it because LeanIMT behaved badly. Turns out that behavior was a bug, fixed here: privacy-scaling-explorations/zk-kit#355
However, the test for that bug points out that people might assume that 0 has special meaning in many situations (including using it to mean removal from a Merkle tree), so it's still a good idea to use a unique non-zero value for PODNull's hash. In this PR I've updated the comment on the related utest to describe the general reasoning, rather than point to LeanIMT in particular.