Added analytics event fully after ctx.waitUntil

proofzero · Sep 21, 2023 · 3a65461 · 3a65461
1 parent ebd995a
commit 3a65461
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 24 deletions.
diff --git a/platform/starbase/src/jsonrpc/methods/publishApp.ts b/platform/starbase/src/jsonrpc/methods/publishApp.ts
@@ -61,19 +61,19 @@ export const publishApp = async ({
 
   await appDO.class.publish(input.published)
 
-  const { edges: ownershipEdges } = await caller.edges.getEdges({
-    query: {
-      tag: EDGE_APPLICATION,
-      dst: { baseUrn: appURN },
-    },
-  })
-  if (ownershipEdges.length === 0) {
-    throw new InternalServerError({
-      message: 'App ownership edge not found',
+  const buildAnalyticsEvent = async () => {
+    const { edges: ownershipEdges } = await caller.edges.getEdges({
+      query: {
+        tag: EDGE_APPLICATION,
+        dst: { baseUrn: appURN },
+      },
     })
-  }
+    if (ownershipEdges.length === 0) {
+      throw new InternalServerError({
+        message: 'App ownership edge not found',
+      })
+    }
 
-  ctx.waitUntil?.(
     createAnalyticsEvent({
       distinctId: ctx.identityURN as IdentityURN,
       eventName: input.published
@@ -89,7 +89,9 @@ export const publishApp = async ({
         },
       },
     })
-  )
+  }
+
+  ctx.waitUntil?.(buildAnalyticsEvent())
 
   return {
     published: true,

diff --git a/platform/starbase/src/jsonrpc/methods/setAppPlan.ts b/platform/starbase/src/jsonrpc/methods/setAppPlan.ts
@@ -82,19 +82,19 @@ export const setAppPlan = async ({
     })
   )
 
-  const { edges: ownershipEdges } = await caller.edges.getEdges({
-    query: {
-      tag: EDGE_APPLICATION,
-      dst: { baseUrn: appURN },
-    },
-  })
-  if (ownershipEdges.length === 0) {
-    throw new InternalServerError({
-      message: 'App ownership edge not found',
+  const buildAnalyticsEvent = async () => {
+    const { edges: ownershipEdges } = await caller.edges.getEdges({
+      query: {
+        tag: EDGE_APPLICATION,
+        dst: { baseUrn: appURN },
+      },
     })
-  }
+    if (ownershipEdges.length === 0) {
+      throw new InternalServerError({
+        message: 'App ownership edge not found',
+      })
+    }
 
-  ctx.waitUntil?.(
     createAnalyticsEvent({
       eventName: `app_set_${plan}_plan`,
       apiKey: ctx.POSTHOG_API_KEY,
@@ -108,5 +108,7 @@ export const setAppPlan = async ({
         },
       },
     })
-  )
+  }
+
+  ctx.waitUntil?.(buildAnalyticsEvent())
 }