chore(passport): add response type parameter to authorization paramet…

…ers (#2682)
proofzero · Sep 14, 2023 · d7b879e · d7b879e
1 parent 9e2db19
commit d7b879e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/apps/passport/app/routes/authenticate/$clientId/account.tsx b/apps/passport/app/routes/authenticate/$clientId/account.tsx
@@ -54,13 +54,15 @@ export const action: ActionFunction = async ({ request, context, params }) => {
     params.clientId
   )
 
-  const { redirectUri, state, scope, clientId, prompt } = authzCookieParams
+  const { redirectUri, state, scope, clientId, prompt, responseType } =
+    authzCookieParams
 
   const qp = new URLSearchParams()
   qp.append('client_id', clientId)
   qp.append('redirect_uri', redirectUri)
   qp.append('state', state)
   qp.append('scope', scope.join(' '))
+  qp.append('response_type', responseType)
 
   if (prompt) qp.append('prompt', prompt)
 

diff --git a/apps/passport/bindings.d.ts b/apps/passport/bindings.d.ts
@@ -55,6 +55,7 @@ declare global {
 
   interface AuthzParams {
     clientId: string
+    response_type: string
     redirectUri: string
     scope: string[]
     state: string

diff --git a/apps/passport/server.ts b/apps/passport/server.ts
@@ -27,6 +27,7 @@ type CustomDomainRequest = Request & {
 export function parseParams(request: Request) {
   const url = new URL(request.url)
   const clientId = url.searchParams.get('client_id') || ''
+  const responseType = url.searchParams.get('response_type') || ''
   const state = url.searchParams.get('state') || ''
   const redirectUri = url.searchParams.get('redirect_uri') || ''
   const scope = url.searchParams.get('scope')
@@ -44,6 +45,7 @@ export function parseParams(request: Request) {
 
   return {
     clientId,
+    responseType,
     state,
     redirectUri,
     scope: decodedScope ? decodedScope.split(' ') : [],