-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Design): Modal Cancel Button #2344
Conversation
f8b38fa
to
64410cb
Compare
f0f3e9d
to
6183ea6
Compare
e.rc.addr_type === CryptoAddressType.ETH | ||
}) | ||
.map((address) => { | ||
return address.qc.alias.toLowerCase() as string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alias for SC wallet is not an Ethereum address, but a Nickname
Because of it, it throws errors from nft gallery that
owner should be a valid address or ENS name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK, some things to consider:
1 - Can these modals be further consolidated into two different types, they seem to share a lot of properties and maybe could be extracted as components (mostly the outer divs)
2 - In Tailwind CSS v3.0, transform and filter utilities like scale-50 and brightness-75 will automatically take effect without needing to add the transform, filter, or backdrop-filter
which means we can remove the transform property
No more transform properties, and I also think consolidation should happen at some point. |
164a6b9
to
a4a8238
Compare
Description
Positions close modal button inside the modal.
Related Issues
Testing
Visual changes were tested on all components locally
Checklist