feat(console): delete app modal checks custom domain config #2373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szkl
requested review from
betimshahini,
poolsar42,
Cosmin-Parvulescu and
maurerbot
|
|
betimshahini
reviewed
Jun 7, 2023
| before you can delete the application. | ||
| </Text> | ||
|
|
||
| <Link to={`/apps/${appDetails.clientId}/domain-wip`} className="self-end"> |
There was a problem hiding this comment.
This will be set to final route as part of #2374
betimshahini
previously approved these changes
Jun 7, 2023
betimshahini
reviewed
Jun 7, 2023
| <HasCustomDomain appDetails={appDetails}></HasCustomDomain> | ||
| )} | ||
| {!hasCustomDomain && ( | ||
| <DeleteModalAppForm |
There was a problem hiding this comment.
The form inside DeleteModalAppForm makes a post to /apps/delete. This API route also needs to do this check on the backend and throw an error.
szkl
force-pushed
the
feat/console/delete-app/custom-domain
branch
from
37f8309
to
b4d56ed
Compare
szkl
commented
Jun 7, 2023
| @@ -28,6 +29,11 @@ export const deleteApp = async ({ | |||
| ctx.StarbaseApp | |||
| ) | |||
|
|
|||
| if (await appDO.storage.get('customDomain')) | |||
| throw new BadRequestError({ | |||
| message: 'HAS_CUSTOM_DOMAIN', | |||
There was a problem hiding this comment.
The code property is restricted but error objects could have another property for enum-like names. In this case, the error representation doesn't depend on the message in the object so using the code name in the message property is pragmatic.
szkl
force-pushed
the
feat/console/delete-app/custom-domain
branch
4 times, most recently
from
27c0844
to
f567f93
Compare
szkl
force-pushed
the
feat/console/delete-app/custom-domain
branch
from
f567f93
to
0654794
Compare
szkl
force-pushed
the
feat/console/delete-app/custom-domain
branch
from
0654794
to
fe9a37a
Compare
|
Updated. |
maurerbot
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The delete application modal displays a message that application has a custom
domain configured.
Related Issues
Testing
Checklist