Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(passport): Connect account button colours regression #2376

Merged

Conversation

Cosmin-Parvulescu
Copy link
Contributor

Description

  • Fixed connect account button color regression
  • Fixed secondary-alt dark mode color
  • Added hover color to select secondary-alt buttons

Related Issues

Testing

Both dark & light mode:
image

Dark:
image
Light:
image

Dark:
image
Light:
image

Dark:
image
Light:
image

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@Cosmin-Parvulescu Cosmin-Parvulescu self-assigned this Jun 7, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu added the bug Indicates an unexpected problem or unintended behavior label Jun 7, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu marked this pull request as ready for review June 7, 2023 13:45
@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the bug/passport/connect-account-button-colours-regression branch 2 times, most recently from 89f8950 to c746407 Compare June 8, 2023 07:58
@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the bug/passport/connect-account-button-colours-regression branch from c746407 to 4294866 Compare June 8, 2023 10:45
@betimshahini betimshahini merged commit b2a37f5 into main Jun 8, 2023
@betimshahini betimshahini deleted the bug/passport/connect-account-button-colours-regression branch June 8, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(passport): Connect account button colours regression
2 participants