Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(passport): Default side image in login page needs to be adjusted for dark mode #2379

Merged
merged 1 commit into from
Jun 8, 2023
Merged

chore(passport): Default side image in login page needs to be adjusted for dark mode #2379

merged 1 commit into from
Jun 8, 2023

Conversation

Cosmin-Parvulescu
Copy link
Contributor

@Cosmin-Parvulescu Cosmin-Parvulescu commented Jun 7, 2023 •
edited
Loading

Description

  • Added transparent background side-graphics image
  • Updated bg-color based on light / dark mode

Related Issues

Testing

image image image

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@Cosmin-Parvulescu Cosmin-Parvulescu added the enhancement Indicates new feature requests label Jun 7, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu self-assigned this Jun 7, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu marked this pull request as ready for review June 7, 2023 14:04
@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the chore/passport/default-side-image-in-login-page-needs-to-be-adjusted-for-dark-mode branch from 41b89e2 to 5cc3870 Compare June 7, 2023 14:59
@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the chore/passport/default-side-image-in-login-page-needs-to-be-adjusted-for-dark-mode branch from 5cc3870 to 5b4854c Compare June 8, 2023 11:04
betimshahini
betimshahini approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@betimshahini betimshahini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yuuuge!

@betimshahini betimshahini merged commit f02ddee into main Jun 8, 2023
@betimshahini betimshahini deleted the chore/passport/default-side-image-in-login-page-needs-to-be-adjusted-for-dark-mode branch June 8, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betimshahini betimshahini betimshahini approved these changes

Assignees

@Cosmin-Parvulescu Cosmin-Parvulescu

Labels
enhancement Indicates new feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore(passport): Default side image in login page needs to be adjusted for dark mode
2 participants
@Cosmin-Parvulescu @betimshahini