feat(console): Service Plan - Application entitlement assignment #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szkl
suggested changes
Jun 30, 2023
Comment on lines
+75
to
+76
| published?: boolean | ||
| createdTimestamp?: number |
There was a problem hiding this comment.
Hmm, I couldn't say; just extracted a type from the initial LoaderData that can be used somewhere else.
apps/console/app/root.tsx
Outdated
| } | ||
| } | ||
|
|
||
| export const loader: LoaderFunction = getRollupReqFunctionErrorWrapper( | ||
| async ({ request, context }) => { | ||
| const jwt = await requireJWT(request) | ||
| const traceHeader = generateTraceContextHeaders(context.traceSpan) | ||
| const parsedJwt = parseJwt(jwt) | ||
| const parsedJwt = parseJwt(jwt!) |
There was a problem hiding this comment.
await requireJWT(request) should be throwing or returning a jwt. The non-null assertion shouldn't be needed.
There was a problem hiding this comment.
Added a check
| @@ -27,6 +27,12 @@ export const loader: LoaderFunction = getRollupReqFunctionErrorWrapper( | |||
| accountURN, | |||
| }) | |||
|
|
|||
| return updatePaymentMethod({ customerID }) | |||
| const headers = request.headers | |||
| const returnURL = headers.get('Referer') as string | |||
There was a problem hiding this comment.
It might be a good idea to check if there is a referer in case of an abnormal request.
I extracted the two methods to make it a bit more readable I guess. |
|
szkl
approved these changes
Jun 30, 2023
szkl
deleted the
feat/console/service-plan-application-entitlement-assignment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
handledmetadata when creating / updating subscriptions. This can be set to whatever value and if it's present in the webhook event, it A - clears it from the subscription and B - returns without updating entitlements. This allows for sychronous payments.pays/app)Related Issues
Testing
nodes/account.tsfile allows one to reset their clientID as well as paymentInformation and existing service plans:After that, it's a matter of going through the flows.
Checklist