feat(workers): posthog env vars and additional events capture #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poolsar42
force-pushed
the
feat/platform-telemetry
branch
from
97682d1
to
5052442
Compare
poolsar42
force-pushed
the
feat/platform-telemetry
branch
from
d4fa804
to
69c6ba7
Compare
szkl
previously approved these changes
Jul 11, 2023
poolsar42
changed the title
| apiKey: ctx.SECRET_POSTHOG_API_KEY, | ||
| properties: { client_id: input.clientId }, | ||
| }) | ||
| } else if (typeof prevPublished !== 'undefined') { |
There was a problem hiding this comment.
I think this can be simplified to else if (appDetails.published) and remove line 35
There was a problem hiding this comment.
if it's not set it'll be underfined which return false in if, so I'll keep it as else is (typeof appDetails.published !== "undefined")
| */ | ||
| await posthogCall({ | ||
| distinctId: ctx.accountURN as string, | ||
| eventName: 'app_unpublished', |
There was a problem hiding this comment.
Set this in a variable from the if check above, and then make the call using the value of the variable. This way we remove one of the posthostCall blocks as apart from the eventName, the other props are exactly the same.
poolsar42
force-pushed
the
feat/platform-telemetry
branch
from
edf67a2
to
88514d1
Compare
betimshahini
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifies middleware to keep track of all routes in workers
Testing
Tested normal behaviour of all apps and then checked all captured events in posthog dashboard
Checklist