Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(groups): DO Binding #2469

Merged
merged 3 commits into from
Jul 11, 2023
Merged

fix(groups): DO Binding #2469

merged 3 commits into from
Jul 11, 2023

Conversation

Cosmin-Parvulescu
Copy link
Contributor

@Cosmin-Parvulescu Cosmin-Parvulescu commented Jul 11, 2023 •
edited
Loading

Description

  • Fixed identity group export. It was exporting Account DO instead of IdentityGroup.
  • Patched query that doubles identity group listings.
  • Added some comments to the webhook for future me.

Testing

  • New group + invite member flow

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@Cosmin-Parvulescu Cosmin-Parvulescu added the bug Indicates an unexpected problem or unintended behavior label Jul 11, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu self-assigned this Jul 11, 2023
@szkl szkl merged commit 8165f54 into main Jul 11, 2023
@szkl szkl deleted the fix/groups/do-binding branch July 11, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szkl szkl szkl approved these changes

@maurerbot maurerbot Awaiting requested review from maurerbot

Assignees

@Cosmin-Parvulescu Cosmin-Parvulescu

Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cosmin-Parvulescu @szkl