-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(console): Billing email #2512
Conversation
a1cd485
to
0f8f91d
Compare
inferredAddressURN = targetAddress?.baseUrn as AddressURN | ||
|
||
if (!inferredAddressURN) { | ||
throw new RollupError({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use an error with an HTTP status code, like BadRequestError or InternalServerError
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed
(address) => address.qc.alias.toLowerCase() === spd.email.toLowerCase() | ||
) | ||
|
||
if (!targetAddress) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same resolution as above. 😁
// addressURN | ||
let inferredAddressURN | ||
if (!paymentData.addressURN) { | ||
const addresses = await accountClient.getAddresses.query({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extract this bit of code into something like a getAddressURNFromEmail() function, so it can also be used in index.tsx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a method to the address router.
@@ -29,47 +29,55 @@ export const action: ActionFunction = getRollupReqFunctionErrorWrapper( | |||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this also do the lookup from email to address? I keep getting Bad Request: AddressURNInput is not a string: undefined
when trying to update my stripe info from the details page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was an oversight in loading the default addressURN, the problem was addressed without needing to lookup address from email.
0f8f91d
to
0368ed2
Compare
Description
Related Issues
Testing
Checklist