Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(infra): Adds kid to Apple OAuth JWT header. #2521

Merged
merged 1 commit into from
Jul 19, 2023
Merged

chore(infra): Adds kid to Apple OAuth JWT header. #2521

merged 1 commit into from
Jul 19, 2023

Conversation

betimshahini
Copy link
Contributor

Description

Adds kid to Apple OAuth JWT that's used as a secret during authorization. This is required now that we have multiple keys configured.

Related Issues

Testing

Used script to generate new secrets that are used in all 3 envs.

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@betimshahini betimshahini marked this pull request as ready for review July 19, 2023 19:46
@betimshahini betimshahini merged commit eec0586 into main Jul 19, 2023
12 checks passed
@betimshahini betimshahini deleted the fix/2517-apple-secrets-rotation-script branch July 19, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poolsar42 poolsar42 poolsar42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore(infra): Rotate Apple creds
2 participants
@betimshahini @poolsar42