Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(console): Screen side image gets downscaled #2528

Merged
merged 2 commits into from
Jul 21, 2023
Merged

fix(console): Screen side image gets downscaled #2528

merged 2 commits into from
Jul 21, 2023

Conversation

Cosmin-Parvulescu
Copy link
Contributor

@Cosmin-Parvulescu Cosmin-Parvulescu commented Jul 20, 2023 •
edited
Loading

Description

  • Added a new image variant in cloudflare: PassportAppCover
  • Hooked variant to designer screen

Related Issues

Testing

  • Upload test cover from Ondrej (870x1306), doesn't get downscaled, uses new variant
  • Uploded app icon, uses old default ('public') variant

Futurestuff

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@Cosmin-Parvulescu Cosmin-Parvulescu added bug Indicates an unexpected problem or unintended behavior enhancement Indicates new feature requests labels Jul 20, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu self-assigned this Jul 20, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu marked this pull request as ready for review July 20, 2023 15:18
@maurerbot maurerbot merged commit b18d69d into main Jul 21, 2023
@maurerbot maurerbot deleted the fix/console/screen-side-image-gets-downscaled branch July 21, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szkl szkl szkl approved these changes

@maurerbot maurerbot maurerbot approved these changes

@betimshahini betimshahini Awaiting requested review from betimshahini

Assignees

@Cosmin-Parvulescu Cosmin-Parvulescu

Labels
bug Indicates an unexpected problem or unintended behavior enhancement Indicates new feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(console): Screen side image gets downscaled
3 participants
@Cosmin-Parvulescu @maurerbot @szkl