Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(console): Handle 3D Secure Events #2529

Merged
merged 21 commits into from
Jul 27, 2023
Merged

chore(console): Handle 3D Secure Events #2529

merged 21 commits into from
Jul 27, 2023

Conversation

poolsar42
Copy link
Collaborator

@poolsar42 poolsar42 commented Jul 20, 2023 •
edited
Loading

Description

Deals with errory payments and handles 3DS events.

Related Issues

Testing

  1. Start stripe CLI
  2. Configure 3DS testing card for stripe payments: 4000000000003220
  3. Try purchasing something from /billing page

Repeat the whole flow and try to purchase something at $clientId/billing page too (our second page from where we can but entitlement)

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@poolsar42 poolsar42 self-assigned this Jul 24, 2023
@poolsar42 poolsar42 force-pushed the chore/2505-console-error-payment branch from 2a63774 to e56a36a Compare July 24, 2023 20:14
@poolsar42 poolsar42 marked this pull request as ready for review July 24, 2023 20:14
@poolsar42 poolsar42 force-pushed the chore/2505-console-error-payment branch from e56a36a to 03af838 Compare July 24, 2023 20:17
@poolsar42 poolsar42 marked this pull request as draft July 24, 2023 22:40
@poolsar42 poolsar42 force-pushed the chore/2505-console-error-payment branch from 132df64 to e0e05c8 Compare July 26, 2023 04:57
@poolsar42 poolsar42 marked this pull request as ready for review July 26, 2023 04:59
Cosmin-Parvulescu
Cosmin-Parvulescu reviewed Jul 26, 2023
View reviewed changes
Copy link
Contributor

@Cosmin-Parvulescu Cosmin-Parvulescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some code duplication that might be extracted out, some unnecessary json castings to and from and I think there are some tens of lines of code that could be removed if you'd hook into the appendToastToFlashSession mechanism.

apps/console/app/entry.server.tsx Outdated
SELF,
`'nonce-${nonce}' ${STRICT_DYNAMIC}`,
'https://js.stripe.com',
'https://maps.googleapis.com',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty much yes
https://stripe.com/docs/security/guide#content-security-policy

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant the google maps thing :)

apps/console/app/routes/__layout/billing/index.tsx Outdated Show resolved Hide resolved
apps/console/app/routes/__layout/billing/index.tsx Outdated Show resolved Hide resolved
apps/console/app/routes/__layout/billing/index.tsx Outdated Show resolved Hide resolved
apps/console/app/routes/__layout/billing/index.tsx Outdated Show resolved Hide resolved
apps/console/app/routes/__layout/billing/webhook.tsx Outdated Show resolved Hide resolved
apps/console/app/routes/apps/$clientId/billing.tsx Outdated Show resolved Hide resolved
apps/console/app/routes/apps/$clientId/billing.tsx Outdated Show resolved Hide resolved
apps/console/app/routes/apps/$clientId/billing.tsx Outdated Show resolved Hide resolved
apps/console/app/utils/stripe.ts Outdated Show resolved Hide resolved
@poolsar42 poolsar42 force-pushed the chore/2505-console-error-payment branch from 01890f3 to 0097c06 Compare July 26, 2023 22:11
@poolsar42 poolsar42 force-pushed the chore/2505-console-error-payment branch from ee057ea to b03909e Compare July 27, 2023 16:15
betimshahini
betimshahini requested changes Jul 27, 2023
View reviewed changes
packages/types/core.ts Outdated Show resolved Hide resolved
apps/console/app/utils.ts Outdated Show resolved Hide resolved
apps/console/app/utils/stripe.ts Outdated Show resolved Hide resolved
apps/console/app/services/billing/stripe.ts Outdated Show resolved Hide resolved
apps/console/app/routes/apps/$clientId/billing.tsx Outdated Show resolved Hide resolved
apps/console/app/routes/__layout/billing/update.tsx Outdated Show resolved Hide resolved
apps/console/app/routes/__layout/billing/index.tsx Outdated Show resolved Hide resolved
packages/design-system/src/atoms/toast/ToastWithLink.tsx Outdated Show resolved Hide resolved
@betimshahini betimshahini merged commit 30dec8d into main Jul 27, 2023
12 checks passed
@betimshahini betimshahini deleted the chore/2505-console-error-payment branch July 27, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cosmin-Parvulescu Cosmin-Parvulescu Cosmin-Parvulescu left review comments

@betimshahini betimshahini betimshahini approved these changes

Assignees

@poolsar42 poolsar42

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore(console): Handle 3D Secure Events
3 participants
@poolsar42 @Cosmin-Parvulescu @betimshahini