fix(billing): reconciliation email parallelization #2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cosmin-Parvulescu
added
the
bug
Cosmin-Parvulescu
force-pushed
the
fix/billing/reconcilliation-email-parallelization
branch
from
3dd769e
to
0d50d34
Compare
Cosmin-Parvulescu
force-pushed
the
fix/billing/reconcilliation-email-parallelization
branch
from
0d50d34
to
6105d9e
Compare
betimshahini
requested changes
Jul 25, 2023
| input.apps | ||
| .filter((a) => Boolean(a.devEmail)) | ||
| .map((app) => { | ||
| ctx.emailClient.sendReconciliationNotification.query({ |
There was a problem hiding this comment.
Can we make this a batch interface instead of parallelizing this? Also, make the proc it a mutation instead of a query, so the batch payload go in the body and not the query params.
Cosmin-Parvulescu
force-pushed
the
fix/billing/reconcilliation-email-parallelization
branch
from
6105d9e
to
ac859d1
Compare
betimshahini
approved these changes
Jul 26, 2023
betimshahini
deleted the
fix/billing/reconcilliation-email-parallelization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Locally, the worker would lose connection with the loop. Parallelizing it seems to fix that.
Testing
Checklist