Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(billing): update plan feature colors #2545

Merged
merged 2 commits into from
Jul 27, 2023
Merged

chore(billing): update plan feature colors #2545

merged 2 commits into from
Jul 27, 2023

Conversation

Cosmin-Parvulescu
Copy link
Contributor

@Cosmin-Parvulescu Cosmin-Parvulescu commented Jul 25, 2023 •
edited
Loading

Description

Related Issues

Testing

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@Cosmin-Parvulescu Cosmin-Parvulescu added the enhancement Indicates new feature requests label Jul 25, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu self-assigned this Jul 25, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu marked this pull request as ready for review July 26, 2023 08:58
@Cosmin-Parvulescu
Copy link
Contributor Author

image image

betimshahini
betimshahini requested changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@betimshahini betimshahini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design was tweaked in product this morning. See update in Figma. See if you can extract the features into a reusable component that can be used in the panel as well as in the tooltip, with appropriate styling tweaks on each.

@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the chore/billing/update-plan-feature-colors branch from ffee1c4 to 77964d2 Compare July 27, 2023 07:55
@Cosmin-Parvulescu Cosmin-Parvulescu force-pushed the chore/billing/update-plan-feature-colors branch from 04be687 to 1ae13b1 Compare July 27, 2023 15:47
@Cosmin-Parvulescu
Copy link
Contributor Author

image image image

@maurerbot maurerbot merged commit b66e6d3 into main Jul 27, 2023
12 checks passed
@maurerbot maurerbot deleted the chore/billing/update-plan-feature-colors branch July 27, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurerbot maurerbot maurerbot approved these changes

@betimshahini betimshahini Awaiting requested review from betimshahini

Assignees

@Cosmin-Parvulescu Cosmin-Parvulescu

Labels
enhancement Indicates new feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore(console): Correcting checkmark colors
3 participants
@Cosmin-Parvulescu @maurerbot @betimshahini