Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(console): Service plan entitlement assignment during 3DS #2556

Merged
merged 7 commits into from
Jul 28, 2023

Conversation

poolsar42
Copy link
Collaborator

Description

Doesn't assign entitlement and ProPlan to app if payment requires additional action

Related Issues

Testing

Buy one entitlement on $clientId/billing page using 3DS card.

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@poolsar42 poolsar42 marked this pull request as ready for review July 27, 2023 21:26

// if this method was called from "$clientId/billing" page, update the plan
// and assign the new plan to the app
if (updatePlanParams.length) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Server-side validation, before entitlement, as per our chat.

@poolsar42 poolsar42 self-assigned this Jul 28, 2023
@betimshahini betimshahini merged commit 0f5c5cd into main Jul 28, 2023
12 checks passed
@betimshahini betimshahini deleted the fix/2555-console-3DS branch July 28, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(console): Service plan entitlement assignment during 3DS
2 participants