Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(edges): Remove now-broken validation check #2566

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

betimshahini
Copy link
Contributor

@betimshahini betimshahini commented Jul 31, 2023

Description

Removing check that no longer works as intended, due to CF backend service changes. result[x].meta.changes no longer returns number of rows affected.
This builds on top of the previous functional PR to add the missing await.

Related Issues

Testing

Setup: Create identities, add accounts.

  • Delete identity and recreate to ensure it's brand new
  • Delete non-primary connected account and make sure it can be reconnected.
  • Change the primary state on an account and try the cases above.

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@betimshahini betimshahini marked this pull request as ready for review July 31, 2023 19:35
@maurerbot maurerbot merged commit 8332a61 into main Jul 31, 2023
12 checks passed
@maurerbot maurerbot deleted the fix/2323-remove-broken-check branch July 31, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants