Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(console): Remove certs when subscription fails and entitlement is removed #2584

Merged
merged 1 commit into from
Aug 9, 2023
Merged

fix(console): Remove certs when subscription fails and entitlement is removed #2584

merged 1 commit into from
Aug 9, 2023

Conversation

Cosmin-Parvulescu
Copy link
Contributor

Description

  • Added custom domain removal step in deleteSubscriptionPlans method

Related Issues

Testing

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@Cosmin-Parvulescu Cosmin-Parvulescu added the bug Indicates an unexpected problem or unintended behavior label Aug 7, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu self-assigned this Aug 7, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu marked this pull request as ready for review August 8, 2023 08:19
@betimshahini betimshahini marked this pull request as draft August 8, 2023 15:15
@betimshahini
Copy link
Contributor

@poolsar42 to review and test.

@betimshahini betimshahini marked this pull request as ready for review August 9, 2023 15:02
@betimshahini betimshahini merged commit 4de0ef1 into main Aug 9, 2023
12 checks passed
@betimshahini betimshahini deleted the fix/console/remove-certs-when-subscription-fails-and-entitlement-is-removed branch August 9, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szkl szkl szkl approved these changes

Assignees

@Cosmin-Parvulescu Cosmin-Parvulescu

Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(console): Remove certs when subscription fails and entitlement is removed
3 participants
@Cosmin-Parvulescu @betimshahini @szkl