Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(console): my auth url #2640

Merged
merged 1 commit into from
Aug 28, 2023
Merged

feat(console): my auth url #2640

merged 1 commit into from
Aug 28, 2023

Conversation

szkl
Copy link
Contributor

@szkl szkl commented Aug 23, 2023 •
edited
Loading

Description

Adds a read only field to test authorization page for the user application.

Related Issues

Testing

  • Console App Dashboard
  • Console App OAuth
  • App with a custom domain

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@szkl szkl marked this pull request as draft August 23, 2023 19:46
@szkl szkl self-assigned this Aug 23, 2023
@szkl szkl added the enhancement Indicates new feature requests label Aug 23, 2023
@szkl
Copy link
Contributor Author

szkl commented Aug 23, 2023 •
edited
Loading

There is a slight difference in the UI design. I have to make structural changes in the markup to match the design exactly. That's why I'm submitting a basic change set.

image
image

@szkl szkl marked this pull request as ready for review August 23, 2023 20:14
@szkl
Copy link
Contributor Author

szkl commented Aug 23, 2023

There is a slight difference in the UI design. I have to make structural changes in the markup to match the design exactly. That's why I'm submitting a basic change set.

@picassobanana could you tell me what you think about this?

@szkl szkl requested a review from maurerbot August 23, 2023 20:19
@szkl szkl marked this pull request as draft August 23, 2023 20:24
@szkl szkl marked this pull request as ready for review August 23, 2023 20:26
@szkl szkl force-pushed the feat/console/my-auth-url branch 2 times, most recently from a2130aa to 81fa118 Compare August 23, 2023 20:27
@picassobanana
Copy link

There is a slight difference in the UI design. I have to make structural changes in the markup to match the design exactly. That's why I'm submitting a basic change set.

@picassobanana could you tell me what you think about this?

Looking good! @szkl We are just missing an apostrophe there in "won’t" and if possible I would also add text-overflow: ellipsis; if the link gets larger than the container.

@szkl
Copy link
Contributor Author

szkl commented Aug 24, 2023

There is a slight difference in the UI design. I have to make structural changes in the markup to match the design exactly. That's why I'm submitting a basic change set.

@picassobanana could you tell me what you think about this?

Looking good! @szkl We are just missing an apostrophe there in "won’t" and if possible I would also add text-overflow: ellipsis; if the link gets larger than the container.

Thanks. The typo is fixed. I'll add the ellipsis.

betimshahini
betimshahini reviewed Aug 24, 2023
View reviewed changes
apps/console/app/routes/apps/$clientId.tsx Outdated

const authorizationScope = appDetails.app?.scopes
? Array.from(appDetails.app.scopes)
: ['openid', 'profile']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove 'profile' from defaults array.

@szkl szkl requested a review from betimshahini August 25, 2023 00:33
@Cosmin-Parvulescu
Copy link
Contributor

Tested with the following two mentions:
1 - Ran into a RollupError: Cloudflare API Error when trying to set up a custom domain so didn't test with custom domain
2 - URL doesn’t work with unpublished app (probably intended?)

@maurerbot
Copy link
Contributor

Disable if not published

@szkl
Copy link
Contributor Author

szkl commented Aug 25, 2023

1 - Ran into a RollupError: Cloudflare API Error when trying to set up a custom domain so didn't test with custom domain

Is the domain used before in any environment?

@Cosmin-Parvulescu
Copy link
Contributor

1 - Ran into a RollupError: Cloudflare API Error when trying to set up a custom domain so didn't test with custom domain

Is the domain used before in any environment?

Domain yeah, subdomain no. I didn't investigate what went wrong, probably not related to PR.

@szkl
Copy link
Contributor Author

szkl commented Aug 25, 2023

2 - URL doesn’t work with unpublished app (probably intended?)
Disable if not published

No behavior change in the passport. Do you mean disable/hide the auth URL?

@szkl
Copy link
Contributor Author

szkl commented Aug 28, 2023

Updated.

image

@betimshahini betimshahini merged commit ddc1ff2 into main Aug 28, 2023
14 checks passed
@betimshahini betimshahini deleted the feat/console/my-auth-url branch August 28, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betimshahini betimshahini betimshahini approved these changes

@Cosmin-Parvulescu Cosmin-Parvulescu Cosmin-Parvulescu left review comments

@poolsar42 poolsar42 Awaiting requested review from poolsar42

@maurerbot maurerbot Awaiting requested review from maurerbot

Assignees

@szkl szkl

Labels
enhancement Indicates new feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(console): Generate authz url with copy function in OAuth settings
5 participants
@szkl @picassobanana @Cosmin-Parvulescu @maurerbot @betimshahini