Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(email): CSS change change for OTP emails and auth side image #2653

Merged
merged 5 commits into from
Aug 30, 2023
Merged

fix(email): CSS change change for OTP emails and auth side image #2653

merged 5 commits into from
Aug 30, 2023

Conversation

Cosmin-Parvulescu
Copy link
Contributor

@Cosmin-Parvulescu Cosmin-Parvulescu commented Aug 30, 2023 •
edited
Loading

Description

  • Added inline styles to Email OTP Template
  • Kept CSS styles for clients that support it
  • Kept light / dark mode in preview
  • Tweaked responsive breakpoint on side graphic
  • Added background-img hack so image doesn't get resized on iOS

Related Issues

Testing

  • Outlook
  • Gmail
  • iOS

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@Cosmin-Parvulescu Cosmin-Parvulescu self-assigned this Aug 30, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu added the bug Indicates an unexpected problem or unintended behavior label Aug 30, 2023
@Cosmin-Parvulescu Cosmin-Parvulescu marked this pull request as ready for review August 30, 2023 15:53
@betimshahini betimshahini merged commit 7236d8e into main Aug 30, 2023
14 checks passed
@betimshahini betimshahini deleted the fix/email/CSS-change-change-for-OTP-emails-and-auth-side-image branch August 30, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betimshahini betimshahini betimshahini approved these changes

Assignees

@Cosmin-Parvulescu Cosmin-Parvulescu

Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
2 participants
@Cosmin-Parvulescu @betimshahini