feat(passport): Add signout link to all error pages #2654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cosmin-Parvulescu
force-pushed
the
feat/passport/add-signout-link-to-all-error-pages
branch
2 times, most recently
from
2af2d16
to
4392e87
Compare
szkl
previously approved these changes
Sep 5, 2023
betimshahini
force-pushed
the
feat/passport/add-signout-link-to-all-error-pages
branch
from
d6abb5e
to
4392e87
Compare
betimshahini
requested changes
Sep 5, 2023
| @@ -370,6 +372,12 @@ export function ErrorBoundary({ error }) { | |||
| <Links /> | |||
| </head> | |||
| <body className="min-h-[100dvh] flex justify-center items-center"> | |||
| <section className="absolute right-0 top-0 p-4"> | |||
There was a problem hiding this comment.
When I got to any invalid URL under passport (add /asdf to any valid URL) and click Sign out on the new error page, I get the following:
This happens regardless of whether the error originated while signed in or not.
If I sign out with the regular Sign out link under the avatar menu, I don't get this error.
szkl
approved these changes
Sep 6, 2023
Cosmin-Parvulescu
force-pushed
the
feat/passport/add-signout-link-to-all-error-pages
branch
from
f362921
to
fddea1e
Compare
Cosmin-Parvulescu
force-pushed
the
feat/passport/add-signout-link-to-all-error-pages
branch
from
fddea1e
to
7d4a12e
Compare
betimshahini
approved these changes
Sep 7, 2023
betimshahini
deleted the
feat/passport/add-signout-link-to-all-error-pages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Testing
Checklist