feat(passport): Passkeys #2659
Merged
feat(passport): Passkeys #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szkl
previously approved these changes
Sep 5, 2023
szkl
reviewed
Sep 6, 2023
apps/passport/.dev.vars.example
Outdated
| @@ -21,3 +21,4 @@ SECRET_APPLE_OAUTH_CLIENT_SECRET="" | |||
| INTERNAL_DISCORD_OAUTH_CLIENT_ID="" | |||
| SECRET_DISCORD_OAUTH_CLIENT_SECRET="" | |||
|
|
|||
| SECRET_WEBAUTHN_SIGNING_KEY='' | |||
There was a problem hiding this comment.
Suggested change
| SECRET_WEBAUTHN_SIGNING_KEY='' | |
| SECRET_WEBAUTHN_SIGNING_KEY='' | |
Comment on lines
172
to
173
| registrationOptions && | ||
| registrationOptions.challenge && |
There was a problem hiding this comment.
Suggested change
| registrationOptions && | |
| registrationOptions.challenge && | |
| registrationOptions?.challenge && |
Comment on lines
+27
to
+31
| if (e instanceof errors.JWTExpired) | ||
| throw new BadRequestError({ | ||
| message: | ||
| 'Passkey request authentication has expired. Please try again.', | ||
| }) |
szkl
reviewed
Sep 6, 2023
|
|
||
| if ( | ||
| !registrationPayload.nickname || | ||
| (registrationPayload.nickname && registrationPayload.nickname.length < 4) |
There was a problem hiding this comment.
Suggested change
| (registrationPayload.nickname && registrationPayload.nickname.length < 4) | |
| (registrationPayload.nickname?.length <= 3) |
There was a problem hiding this comment.
Keeping the number in the condition as it matches with the error message. Addressed the null item.
There was a problem hiding this comment.
but the error message says 4 or more. It doesn't accept 4 letter names.
There was a problem hiding this comment.
Good catch, though that was happening in the component, and not this bit of code. Updated the component condition to be the same < 4 so should be consistent in front and backend.
There was a problem hiding this comment.
I just searched for < 4 and posted the comment. I wasn't paying enough attention 🤭
szkl
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements registration and login of passkeys
Related Issues
Testing
Checklist